Skip to content

Commit

Permalink
[8.x] Remove usage of Kibana plugins build in performance test pipeli…
Browse files Browse the repository at this point in the history
…nes (#205896) (#205930)

# Backport

This will backport the following commits from `main` to `8.x`:
- [Remove usage of Kibana plugins build in performance test pipelines
(#205896)](#205896)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Robert
Oskamp","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-01-08T16:15:33Z","message":"Remove
usage of Kibana plugins build in performance test pipelines
(#205896)\n\n## Summary\r\n\r\nThis PR fixes the performance test
pipelines by removing the bits that\r\nrely on the plugins
build.\r\n\r\n### Details\r\n\r\n* The plugin build has been removed
with #197125. Since the performance\r\npipelines are running against a
Kibana build (and not against sources),\r\nthey should not need the
plugin build.\r\n* The `performance-data-set-extraction` pipeline
started to fail\r\nimmediately after the plugin build has been
removed\r\n* This failure went unnoticed since the
`scalability-benchmarking`\r\npipeline continued to work by using the
last uploaded artifacts from the\r\n`performance-data-set-extraction`
pipeline, which were available for\r\nanother month. Once the old
artifacts were no longer available, the\r\n`scalability-benchmarking`
pipeline also started to
fail.","sha":"9bdc995d3c6f1c19d242d411e039e1c9c5c6251f","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor","v8.18.0"],"title":"Remove
usage of Kibana plugins build in performance test
pipelines","number":205896,"url":"https://github.com/elastic/kibana/pull/205896","mergeCommit":{"message":"Remove
usage of Kibana plugins build in performance test pipelines
(#205896)\n\n## Summary\r\n\r\nThis PR fixes the performance test
pipelines by removing the bits that\r\nrely on the plugins
build.\r\n\r\n### Details\r\n\r\n* The plugin build has been removed
with #197125. Since the performance\r\npipelines are running against a
Kibana build (and not against sources),\r\nthey should not need the
plugin build.\r\n* The `performance-data-set-extraction` pipeline
started to fail\r\nimmediately after the plugin build has been
removed\r\n* This failure went unnoticed since the
`scalability-benchmarking`\r\npipeline continued to work by using the
last uploaded artifacts from the\r\n`performance-data-set-extraction`
pipeline, which were available for\r\nanother month. Once the old
artifacts were no longer available, the\r\n`scalability-benchmarking`
pipeline also started to
fail.","sha":"9bdc995d3c6f1c19d242d411e039e1c9c5c6251f"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/205896","number":205896,"mergeCommit":{"message":"Remove
usage of Kibana plugins build in performance test pipelines
(#205896)\n\n## Summary\r\n\r\nThis PR fixes the performance test
pipelines by removing the bits that\r\nrely on the plugins
build.\r\n\r\n### Details\r\n\r\n* The plugin build has been removed
with #197125. Since the performance\r\npipelines are running against a
Kibana build (and not against sources),\r\nthey should not need the
plugin build.\r\n* The `performance-data-set-extraction` pipeline
started to fail\r\nimmediately after the plugin build has been
removed\r\n* This failure went unnoticed since the
`scalability-benchmarking`\r\npipeline continued to work by using the
last uploaded artifacts from the\r\n`performance-data-set-extraction`
pipeline, which were available for\r\nanother month. Once the old
artifacts were no longer available, the\r\n`scalability-benchmarking`
pipeline also started to
fail.","sha":"9bdc995d3c6f1c19d242d411e039e1c9c5c6251f"}},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Robert Oskamp <[email protected]>
  • Loading branch information
kibanamachine and pheyos authored Jan 9, 2025
1 parent a7ed0e8 commit 5106868
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,6 @@ buildkite-agent artifact upload "${OUTPUT_DIR}/scalability_traces.tar.gz"

echo "--- Downloading Kibana artifacts used in tests"
download_artifact kibana-default.tar.gz "${OUTPUT_DIR}/" --build "${KIBANA_BUILD_ID:-$BUILDKITE_BUILD_ID}"
download_artifact kibana-default-plugins.tar.gz "${OUTPUT_DIR}/" --build "${KIBANA_BUILD_ID:-$BUILDKITE_BUILD_ID}"

echo "--- Adding commit info"
echo "${BUILDKITE_COMMIT}" > "${OUTPUT_DIR}/KIBANA_COMMIT_HASH"
Expand Down
1 change: 0 additions & 1 deletion .buildkite/scripts/steps/scalability/benchmarking.sh
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,6 @@ download_artifacts() {
tar -xzf "${LATEST_RUN_ARTIFACTS_DIR}/kibana-default.tar.gz" -C "$KIBANA_BUILD_LOCATION" --strip=1

cd "$KIBANA_DIR"
tar -xzf "${LATEST_RUN_ARTIFACTS_DIR}/kibana-default-plugins.tar.gz"
tar -xzf "${LATEST_RUN_ARTIFACTS_DIR}/scalability_traces.tar.gz"
}

Expand Down

0 comments on commit 5106868

Please sign in to comment.