-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Security Solution] Fix timeline dynamic batching #204034
Merged
PhilippeOberti
merged 25 commits into
elastic:main
from
logeekal:fix/timeline_dynamic_batching
Jan 7, 2025
+796
−1,027
Merged
Changes from all commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
772a28e
fix: all fields
logeekal c7bace8
incremental save
logeekal 7fae6ef
fix: batchination 😎
logeekal 7e4678e
test: more ...
logeekal d6effb8
fix: housekeeping
logeekal d4ab95d
Allow querysize upto the default limit
logeekal 4f01960
fix: translations
logeekal ccdb04f
fix: tests
logeekal ac56a3d
fix: tests
logeekal b258aa1
incremental save
logeekal 6650a9c
fix: new batching logic + tests
logeekal 156c30b
fix: more hardening
logeekal 47fff64
fix: remove unnecessary code
logeekal ac6dfcc
fix: more tests
logeekal 62098dd
fix: better tests
logeekal b5ee55d
Tests: query tab integration
logeekal 682512e
fix: simple test
logeekal c60fc77
fix: types
logeekal 0d14ccc
fix: tests
logeekal ea947e9
fix: housekeeping
logeekal 0d56360
fix: bug where queries are emptied
logeekal a599ac6
feedback
logeekal 534f691
Merge branch 'main' into fix/timeline_dynamic_batching
PhilippeOberti 80e2e9e
[CI] Auto-commit changed files from 'node scripts/styled_components_m…
kibanamachine f135834
Merge branch 'main' into fix/timeline_dynamic_batching
logeekal File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
51 changes: 51 additions & 0 deletions
51
...ons/security/plugins/security_solution/public/common/mock/mock_timeline_search_service.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,51 @@ | ||
/* | ||
* Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
* or more contributor license agreements. Licensed under the Elastic License | ||
* 2.0; you may not use this file except in compliance with the Elastic License | ||
* 2.0. | ||
*/ | ||
|
||
import { mockTimelineData } from './mock_timeline_data'; | ||
|
||
const mockEvents = structuredClone(mockTimelineData); | ||
|
||
/* | ||
* This helps to mock `data.search.search` method to mock the timeline data | ||
* */ | ||
export const getMockTimelineSearchSubscription = () => { | ||
const mockSearchWithArgs = jest.fn(); | ||
|
||
const mockTimelineSearchSubscription = jest.fn().mockImplementation((args) => { | ||
mockSearchWithArgs(args); | ||
return { | ||
subscribe: jest.fn().mockImplementation(({ next }) => { | ||
const start = args.pagination.activePage * args.pagination.querySize; | ||
const end = start + args.pagination.querySize; | ||
const timelineOut = setTimeout(() => { | ||
next({ | ||
isRunning: false, | ||
isPartial: false, | ||
inspect: { | ||
dsl: [], | ||
response: [], | ||
}, | ||
edges: mockEvents.map((item) => ({ node: item })).slice(start, end), | ||
pageInfo: { | ||
activePage: args.pagination.activePage, | ||
querySize: args.pagination.querySize, | ||
}, | ||
rawResponse: {}, | ||
totalCount: mockEvents.length, | ||
}); | ||
}, 50); | ||
return { | ||
unsubscribe: jest.fn(() => { | ||
clearTimeout(timelineOut); | ||
}), | ||
}; | ||
}), | ||
}; | ||
}); | ||
|
||
return { mockTimelineSearchSubscription, mockSearchWithArgs }; | ||
}; |
236 changes: 0 additions & 236 deletions
236
...rity/plugins/security_solution/public/timelines/components/timeline/footer/index.test.tsx
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there's
VoidFunction
type :)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Done here: a599ac6