[Rules migration] Add Integrations column (#11387) #204639
Merged
+425
−59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e40pud
added
release_note:skip
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
|
Pinging @elastic/security-threat-hunting (Team:Threat Hunting) |
e40pud
commented
Dec 17, 2024
| username: string, | ||
| esClient: ElasticsearchClient, | ||
| logger: Logger, | ||
| private packageService?: PackageService |
There was a problem hiding this comment.
I don't think it's the best approach to drill a hole through the ruleMigration classes whenever we need a new client/service from the context. But we can keep it this way until we implement a more generic way to get them.
semd
reviewed
Dec 17, 2024
...ons/security/plugins/security_solution/server/lib/siem_migrations/siem_migrations_service.ts
Outdated
Show resolved
Hide resolved
elastic-vault-github-plugin-prod
bot
requested a review
from a team
as a code owner
semd
reviewed
Dec 19, 2024
src/plugins/visualizations/public/legacy/embeddable/visualize_embeddable.tsx
Outdated
Show resolved
Hide resolved
semd
reviewed
Dec 19, 2024
x-pack/solutions/security/plugins/security_solution/common/siem_migrations/constants.ts
Show resolved
Hide resolved
semd
reviewed
Dec 19, 2024
| @@ -396,6 +396,26 @@ paths: | |||
| additionalProperties: | |||
| $ref: '../../rule_migration.schema.yaml#/components/schemas/PrebuiltRuleVersion' | |||
|
|
|||
| /internal/siem_migrations/rules/{migration_id}/integrations: | |||
There was a problem hiding this comment.
Do we have the {migration_id} in the path? I am confused
There was a problem hiding this comment.
This needs to be /internal/siem_migrations/rules/integrations
semd
reviewed
Dec 19, 2024
| @@ -43,7 +44,7 @@ export interface PrebuiltRulesResults { | |||
| * @param rulesIds The list of IDs to filter requested prebuilt rules. If not specified, all available prebuilt rules will be returned. | |||
| * @returns | |||
| */ | |||
| export const getPrebuiltRules = async ( | |||
| export const getPrebuiltRulesByIds = async ( | |||
There was a problem hiding this comment.
Not sure about this rename, ruleIds is an optional parameter
There was a problem hiding this comment.
will switch it back 👍
semd
reviewed
Dec 19, 2024
| @@ -31,7 +31,7 @@ export class SiemMigrationsService { | |||
| } | |||
|
|
|||
| createRulesClient(params: SiemRuleMigrationsCreateClientParams): SiemRuleMigrationsClient { | |||
| return this.rules.createClient(params); | |||
| return this.rules.createClient({ ...params }); | |||
There was a problem hiding this comment.
this is leftover from my previous approach, where I. was passing packageService here.. will clean it up
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
History
cc @e40pud |
|
Starting backport for target branches: 8.x |
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
e40pud
added a commit
to e40pud/kibana
that referenced
this pull request
Jan 9, 2025
…4639) ## Summary [Internal link](elastic/security-team#10820) to the feature details These changes add a functionality which enables related integrations functionality for migration rules: * related integration are shown in the migration rules table * user can navigate to the integration page to see instructions about installation process ### Other tasks and fixes * Default sorting in the table (by `Stats` => by `Author` => by `Severity` => by `Updated`) > [!NOTE] > This feature needs `siemMigrationsEnabled` experimental flag enabled to work. ## Screen recording <img width="1838" alt="Screenshot 2024-12-17 at 19 26 47" src="https://github.com/user-attachments/assets/c1ed9d5d-e237-4dfe-b144-a80adbf46cd3" /> --------- Co-authored-by: kibanamachine <[email protected]> (cherry picked from commit 019f0e8)
e40pud
added a commit
that referenced
this pull request
Jan 9, 2025
…206005) # Backport This will backport the following commits from `main` to `8.x`: - [[Rules migration] Add Integrations column (#11387) (#204639)](#204639) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Ievgen Sorokopud","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-01-08T15:57:24Z","message":"[Rules migration] Add Integrations column (#11387) (#204639)\n\n## Summary\r\n\r\n[Internal link](https://github.com/elastic/security-team/issues/10820)\r\nto the feature details\r\n\r\nThese changes add a functionality which enables related integrations\r\nfunctionality for migration rules:\r\n* related integration are shown in the migration rules table\r\n* user can navigate to the integration page to see instructions about\r\ninstallation process\r\n\r\n### Other tasks and fixes\r\n\r\n* Default sorting in the table (by `Stats` => by `Author` => by\r\n`Severity` => by `Updated`)\r\n\r\n> [!NOTE] \r\n> This feature needs `siemMigrationsEnabled` experimental flag enabled\r\nto work.\r\n\r\n## Screen recording\r\n\r\n<img width=\"1838\" alt=\"Screenshot 2024-12-17 at 19 26 47\"\r\nsrc=\"https://github.com/user-attachments/assets/c1ed9d5d-e237-4dfe-b144-a80adbf46cd3\"\r\n/>\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"019f0e84146e668376f923c0c77ef48f5c302e68","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Threat Hunting","Team: SecuritySolution","backport:prev-minor"],"number":204639,"url":"https://github.com/elastic/kibana/pull/204639","mergeCommit":{"message":"[Rules migration] Add Integrations column (#11387) (#204639)\n\n## Summary\r\n\r\n[Internal link](https://github.com/elastic/security-team/issues/10820)\r\nto the feature details\r\n\r\nThese changes add a functionality which enables related integrations\r\nfunctionality for migration rules:\r\n* related integration are shown in the migration rules table\r\n* user can navigate to the integration page to see instructions about\r\ninstallation process\r\n\r\n### Other tasks and fixes\r\n\r\n* Default sorting in the table (by `Stats` => by `Author` => by\r\n`Severity` => by `Updated`)\r\n\r\n> [!NOTE] \r\n> This feature needs `siemMigrationsEnabled` experimental flag enabled\r\nto work.\r\n\r\n## Screen recording\r\n\r\n<img width=\"1838\" alt=\"Screenshot 2024-12-17 at 19 26 47\"\r\nsrc=\"https://github.com/user-attachments/assets/c1ed9d5d-e237-4dfe-b144-a80adbf46cd3\"\r\n/>\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"019f0e84146e668376f923c0c77ef48f5c302e68"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/204639","number":204639,"mergeCommit":{"message":"[Rules migration] Add Integrations column (#11387) (#204639)\n\n## Summary\r\n\r\n[Internal link](https://github.com/elastic/security-team/issues/10820)\r\nto the feature details\r\n\r\nThese changes add a functionality which enables related integrations\r\nfunctionality for migration rules:\r\n* related integration are shown in the migration rules table\r\n* user can navigate to the integration page to see instructions about\r\ninstallation process\r\n\r\n### Other tasks and fixes\r\n\r\n* Default sorting in the table (by `Stats` => by `Author` => by\r\n`Severity` => by `Updated`)\r\n\r\n> [!NOTE] \r\n> This feature needs `siemMigrationsEnabled` experimental flag enabled\r\nto work.\r\n\r\n## Screen recording\r\n\r\n<img width=\"1838\" alt=\"Screenshot 2024-12-17 at 19 26 47\"\r\nsrc=\"https://github.com/user-attachments/assets/c1ed9d5d-e237-4dfe-b144-a80adbf46cd3\"\r\n/>\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"019f0e84146e668376f923c0c77ef48f5c302e68"}}]}] BACKPORT-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Internal link to the feature details
These changes add a functionality which enables related integrations functionality for migration rules:
Other tasks and fixes
Stats=> byAuthor=> bySeverity=> byUpdated)Note
This feature needs
siemMigrationsEnabledexperimental flag enabled to work.Screen recording