Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fleet] Fix required validation for multi text input field #205768

Merged
merged 2 commits into from
Jan 9, 2025

Conversation

viajes7
Copy link
Contributor

@viajes7 viajes7 commented Jan 7, 2025

Summary

Fixes #196648

  • ✅ add required validation to blank spaces value
  • ❓ when adding additional rows for path. It seems that the updated value is specially processed.

And this is why the required validation is not triggered when clicking to add a row.

image

After fixup

image

@viajes7 viajes7 requested a review from a team as a code owner January 7, 2025 15:18
@botelastic botelastic bot added the Team:Fleet Team label for Observability Data Collection Fleet team label Jan 7, 2025
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@viajes7 viajes7 force-pushed the fix/integration-path-required branch from 0e03287 to cf03fc6 Compare January 7, 2025 15:19
@viajes7
Copy link
Contributor Author

viajes7 commented Jan 7, 2025

Hi, @kpollich Can you help review the pr? Thanks.

@viajes7 viajes7 force-pushed the fix/integration-path-required branch from cf03fc6 to fc3d720 Compare January 7, 2025 15:22
@kpollich
Copy link
Member

kpollich commented Jan 7, 2025

buildkite test this

@kpollich kpollich added backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) release_note:fix labels Jan 7, 2025
@kpollich kpollich self-assigned this Jan 7, 2025
Copy link
Contributor

@jen-huang jen-huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, thanks for the tests

@juliaElastic juliaElastic merged commit 74da51f into elastic:main Jan 9, 2025
12 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/12687589427

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jan 9, 2025
…05768)

## Summary

Fixes elastic#196648

- ✅  add required validation to blank spaces value
- ❓ when adding additional rows for path. It seems that the updated
value is specially processed.

**And this is why the required validation is not triggered when clicking
to add a row.**

![image](https://github.com/user-attachments/assets/f2f0d813-3762-47c5-bf31-1171c82c3b07)

## After fixup

![image](https://github.com/user-attachments/assets/857bef47-38c1-4951-8ea9-15b5ef5d143d)

(cherry picked from commit 74da51f)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

Zacqary pushed a commit to Zacqary/kibana that referenced this pull request Jan 9, 2025
…05768)

## Summary

Fixes elastic#196648 

- ✅  add required validation to blank spaces value
- ❓ when adding additional rows for path. It seems that the updated
value is specially processed.

**And this is why the required validation is not triggered when clicking
to add a row.**


![image](https://github.com/user-attachments/assets/f2f0d813-3762-47c5-bf31-1171c82c3b07)

## After fixup


![image](https://github.com/user-attachments/assets/857bef47-38c1-4951-8ea9-15b5ef5d143d)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) 💝community release_note:fix Team:Fleet Team label for Observability Data Collection Fleet team v9.0.0
Projects
None yet
6 participants