-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fleet] Fix required validation for multi text input field #205768
[Fleet] Fix required validation for multi text input field #205768
Conversation
Pinging @elastic/fleet (Team:Fleet) |
0e03287
to
cf03fc6
Compare
Hi, @kpollich Can you help review the pr? Thanks. |
cf03fc6
to
fc3d720
Compare
buildkite test this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM, thanks for the tests
Starting backport for target branches: 8.x |
…05768) ## Summary Fixes elastic#196648 - ✅ add required validation to blank spaces value - ❓ when adding additional rows for path. It seems that the updated value is specially processed. **And this is why the required validation is not triggered when clicking to add a row.** ![image](https://github.com/user-attachments/assets/f2f0d813-3762-47c5-bf31-1171c82c3b07) ## After fixup ![image](https://github.com/user-attachments/assets/857bef47-38c1-4951-8ea9-15b5ef5d143d) (cherry picked from commit 74da51f)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
…05768) ## Summary Fixes elastic#196648 - ✅ add required validation to blank spaces value - ❓ when adding additional rows for path. It seems that the updated value is specially processed. **And this is why the required validation is not triggered when clicking to add a row.** ![image](https://github.com/user-attachments/assets/f2f0d813-3762-47c5-bf31-1171c82c3b07) ## After fixup ![image](https://github.com/user-attachments/assets/857bef47-38c1-4951-8ea9-15b5ef5d143d)
Summary
Fixes #196648
And this is why the required validation is not triggered when clicking to add a row.
After fixup