[ Security Solution ] Fix Refetch logic with new timeline batching #205893
+116
−35
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
PR : #204034 fixed some issues with timeline batching. It was not able to fix one of the issue with
Refetch
logic which exists inmain
( resulting in a flaky test ) and causing some tests to fail in8.16
,8.17
and8.x
.Issue Description
There are 2 issues with below video:
Refetch
only happens on the firstbatch
, which is an incorrect behaviour. We should fetch all the existing batches.main_reftech_issue.mp4
fix_refetch_alert_status_change.mp4
Refresh
manually, then also only firstbatch
is fetched, which should have rather fetched all the present batches.Main_refetch_refresh_issue.mp4
fix_refetch_refresh_issue.mp4
This is not a new issue and it existed before as well but this change in batching highlighted it.
Checklist
Check the PR satisfies following conditions.
Reviewers should verify this PR satisfies this list as well.