Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ Security Solution ] Fix Refetch logic with new timeline batching #205893

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

logeekal
Copy link
Contributor

@logeekal logeekal commented Jan 8, 2025

Summary

PR : #204034 fixed some issues with timeline batching. It was not able to fix one of the issue with Refetch logic which exists in main ( resulting in a flaky test ) and causing some tests to fail in 8.16, 8.17 and 8.x.

Issue Description

There are 2 issues with below video:

  1. When user updates a status of an alert, the Refetch only happens on the first batch, which is an incorrect behaviour. We should fetch all the existing batches.
Before After Fix
main_reftech_issue.mp4
fix_refetch_alert_status_change.mp4
  1. When user clicks Refresh manually, then also only first batch is fetched, which should have rather fetched all the present batches.
Before After fix
Main_refetch_refresh_issue.mp4
fix_refetch_refresh_issue.mp4

This is not a new issue and it existed before as well but this change in batching highlighted it.

Checklist

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.

@logeekal logeekal added release_note:skip Skip the PR/issue when compiling release notes Team:Threat Hunting:Investigations Security Solution Investigations Team labels Jan 8, 2025
@logeekal logeekal marked this pull request as ready for review January 8, 2025 14:16
@logeekal logeekal requested a review from a team as a code owner January 8, 2025 14:16
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting-investigations (Team:Threat Hunting:Investigations)

@elasticmachine
Copy link
Contributor

⏳ Build in-progress, with failures

Failed CI Steps

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:Threat Hunting:Investigations Security Solution Investigations Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants