Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.x] [Profiling UI] Remove redundant page separator (#206004) #206136

Merged
merged 1 commit into from
Jan 9, 2025
Merged

[8.x] [Profiling UI] Remove redundant page separator (#206004) #206136

merged 1 commit into from
Jan 9, 2025
+0 −2

Conversation

kibanamachine
Copy link
Contributor

Backport

This will backport the following commits from main to 8.x:

Questions ?

Please refer to the Backport tool documentation

@miloszmarcinkowski
[Profiling UI] Remove redundant page separator (elastic#206004)
896e761 
Closes elastic#206002

## Summary

This PR removes redundant page separator to save up some space.

Before:

<img width="1727" alt="Screenshot 2025-01-08 at 16 16 50"
src="https://github.com/user-attachments/assets/9f69ebb2-d1a7-430e-9d9e-376712909ac1"
/>

After:

<img width="1728" alt="Screenshot 2025-01-08 at 16 19 34"
src="https://github.com/user-attachments/assets/9d738aa0-adba-46f3-ba79-5f20b7b90499"
/>

(cherry picked from commit 96ea010)
@kibanamachine kibanamachine force-pushed the backport/8.x/pr-206004 branch from 04692b9 to 896e761 Compare January 9, 2025 20:37
@kibanamachine kibanamachine enabled auto-merge (squash) January 9, 2025 20:37
@kibanamachine kibanamachine mentioned this pull request Jan 9, 2025
Merged
@kibanamachine kibanamachine merged commit 0f34a64 into elastic:8.x Jan 9, 2025
8 checks passed
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
profiling 404.1KB 404.1KB -40.0B

cc @miloszmarcinkowski

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] approved these changes

Assignees

@miloszmarcinkowski miloszmarcinkowski

Labels
backport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kibanamachine @elasticmachine @miloszmarcinkowski