Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deprecated warnings to TestClient on use of timeout argument #2840

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

iudeen
Copy link
Contributor

@iudeen iudeen commented Jan 4, 2025

Implements the solution in #1108 (comment)

Checklist

  • I understand that this PR may be closed in case there was no previous discussion. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.

@iudeen iudeen marked this pull request as ready for review January 4, 2025 11:36
@iudeen iudeen requested a review from Kludex January 4, 2025 11:36
@iudeen
Copy link
Contributor Author

iudeen commented Jan 4, 2025

@lealre I like the way you had created the test! I added that part of it from your PR. 😄

@Kludex Kludex changed the title Add deprecated warnings to TestClient on use of timeout argument. Add deprecated warnings to TestClient on use of timeout argument Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant