-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Complete OpenAI to AWS Bedrock conversion #64
Conversation
yuzisun
commented
Jan 5, 2025
•
edited
Loading
edited
- Complete OpenAI Chat completion and AWSBedrock Converse type definition
- Additional conversion for InferenceConfiguration and ToolConfig
- Error handling and convert to OpenAI error
- Convert to table testing and add more tests
@yuzisun the e2e tests are failing https://github.com/envoyproxy/ai-gateway/actions/runs/12624576475/job/35175024164?pr=64 due to some parsing errors ai-gateway/tests/extproc/extproc_test.go Lines 73 to 101 in 1390554
|
Ah looks like you are using the new type |
yeah - so we need basically the manual type checking logic to support unions on .contents to be compatible with openai i guess. the ChatCompletionNewParams can actually be accepted by them and that use is the example from go-sdk https://github.com/openai/openai-go?tab=readme-ov-file#usage |
Signed-off-by: Dan Sun <[email protected]>
Signed-off-by: Dan Sun <[email protected]>
Signed-off-by: Dan Sun <[email protected]>
Signed-off-by: Dan Sun <[email protected]>
Signed-off-by: Dan Sun <[email protected]>
you can ignore |
Signed-off-by: Dan Sun <[email protected]>
@mathetake The new schema is quite complex which took me a little more time, unfortunately we have to manually craft the types as openai-go did not expose the unmarshall APIs. I need to run the e2e test again, how do I trigger it ? |
Signed-off-by: Dan Sun <[email protected]>
Signed-off-by: Dan Sun <[email protected]>
Signed-off-by: Dan Sun <[email protected]>
Signed-off-by: Dan Sun <[email protected]>
Signed-off-by: Takeshi Yoneda <[email protected]>
@yuzisun thank you for the excellent job here!! |