fix hcm fuzz test case (#37901)

Commit Message: fix hcm fuzz test case Additional Description: This PR fixes a fuzzer issue caused by the fuzzer sending trailers to the HCM then calling continueDecoding (which then hits [this assertion](https://github.com/search?q=repo%3Aenvoyproxy%2Fenvoy%20ASSERT(!state_.decoder_filter_chain_complete_)%3B&type=code) in the HCM and fails). This PR adds a check to prevent this from happening. Risk Level: none, test only Testing: fuzz fix Docs Changes: none Release Notes: none Platform Specific Features: none Signed-off-by: antoniovleonti <[email protected]>
envoyproxy · Jan 6, 2025 · 29428f9 · 29428f9
1 parent 5ccb21d
commit 29428f9
Show file tree

Hide file tree

Showing 2 changed files with 66 additions and 1 deletion.
diff --git a/test/common/http/conn_manager_impl_corpus/maybe_end_decode b/test/common/http/conn_manager_impl_corpus/maybe_end_decode
diff --git a/test/common/http/conn_manager_impl_fuzz_test.cc b/test/common/http/conn_manager_impl_fuzz_test.cc
@@ -482,7 +482,7 @@ class FuzzStream {
       break;
     }
     case test::common::http::RequestAction::kContinueDecoding: {
-      if (!decoding_done_ &&
+      if (!decoding_done_ && state != StreamState::Closed &&
           (header_status_ == FilterHeadersStatus::StopAllIterationAndBuffer ||
            header_status_ == FilterHeadersStatus::StopAllIterationAndWatermark ||
            header_status_ == FilterHeadersStatus::StopIteration) &&