Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor ext_proc client code to remove dynamic_cast #37904

Open
yanjunxiang-google opened this issue Jan 7, 2025 · 0 comments
Open

Refactor ext_proc client code to remove dynamic_cast #37904

yanjunxiang-google opened this issue Jan 7, 2025 · 0 comments
Labels
area/ext_proc help wanted Needs help! tech debt

Comments

@yanjunxiang-google
Copy link
Contributor

yanjunxiang-google commented Jan 7, 2025 •
edited
Loading

Title: Refactor ext_proc client code to remove dynamic_cast

Description:

Remove this dynamic_cast here:

envoy/source/extensions/filters/http/ext_proc/client_impl.cc

Line 30 in 29428f9

ExternalProcessorStream* grpc_stream = dynamic_cast<ExternalProcessorStream*>(stream);

For more details please check: #35740 (comment)
@yanjunxiang-google yanjunxiang-google added the triage Issue requires triage label Jan 7, 2025
@yanjunxiang-google yanjunxiang-google mentioned this issue Jan 7, 2025
Open
@zuercher zuercher added tech debt area/ext_proc help wanted Needs help! and removed triage Issue requires triage labels Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/ext_proc help wanted Needs help! tech debt
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zuercher @yanjunxiang-google