Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: making it clear when the ical code isn't working #37894

Merged
merged 1 commit into from
Jan 7, 2025
Merged

tools: making it clear when the ical code isn't working #37894

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions tools/repo/notify.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,8 +150,7 @@ async def oncall_slack_handle(self):
opsgenie_name = opsgenie_string.split(' ', 1)[0]
# Check that the name is in the OPSGENIE_TO_SLACK list, else cc alyssa.
if not (uid := self.opsgenie_to_slack.get(opsgenie_name)):
print("could not find", opsgenie_name)
return self.opsgenie_to_slack.get('Alyssa')
return None
return uid

@cached_property
Expand Down Expand Up @@ -265,8 +264,13 @@ async def post_to_oncall(self):
oncall = await self.oncall_string
await self.send_message(channel='#envoy-maintainer-oncall', text=(f"{oncall}"))
await self.send_message(channel='#general', text=(f"{oncall}"))
await self.send_message(
channel='#envoy-maintainer-oncall', text=(f"Oncall now <@{oncall_handle}>"))
if not oncall_handle:
await self.send_message(
channel='#envoy-maintainer-oncall',
text=(f"Unable to determine oncall <!here>"))
else:
await self.send_message(
channel='#envoy-maintainer-oncall', text=(f"Oncall now <@{oncall_handle}>"))
await self.send_message(
channel='#envoy-maintainer-oncall',
text=(f"*'Unassigned' PRs* (PRs with no maintainer assigned)\n{unassigned}"))
Expand Down