fix: explicitly set ip family and family policy in gateway spec

[tekulvw]

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #5004

Release Notes: Yes/No

[arkodg]

the PR looks good @tekulvw !
can we make sure there is a test for this and a unique service is generated https://github.com/envoyproxy/gateway/blob/main/internal/infrastructure/kubernetes/proxy/resource_provider_test.go

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.69%. Comparing base (c534621) to head (86411cc).
Report is 9 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #5019      +/-   ##
==========================================
- Coverage   66.73%   66.69%   -0.05%     
==========================================
  Files         209      209              
  Lines       32058    32264     +206     
==========================================
+ Hits        21394    21518     +124     
- Misses       9385     9445      +60     
- Partials     1279     1301      +22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[tekulvw]

Should be good to go @arkodg

[arkodg]

thanks @tekulvw , can you also add a test case to TestService ?

[tekulvw]

@arkodg added, that look okay?

[arkodg]

@tekulvw I was referring to this function

gateway/internal/infrastructure/kubernetes/proxy/resource_provider_test.go

Line 1065 in 52f31b1

func TestService(t *testing.T) {

, by adding a test case here, you'd also need to add a corresponding testdata file in https://github.com/envoyproxy/gateway/tree/main/internal/infrastructure/kubernetes/proxy/testdata/services for both ipFamily: DualStack and ipFamily: IPv6, this is visually an easier way to catch regressions

[tekulvw]

Yeah I just realized, are there docs for setting up local test envs?

The new files I added should suffice.

[arkodg]

Yeah I just realized, are there docs for setting up local test envs?

The new files I added should suffice.

you can verify locally using make test , https://gateway.envoyproxy.io/contributions/develop/ should have more info

[arkodg]

LGTM thanks !