-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add post about the pipeline approach #88
base: main
Are you sure you want to change the base?
Conversation
replace integrate with connect, refer to a graph as a set of connected or related elements. homogenize first sentence of each pipeline. replace question at the end.
Thanks for writing this @avallecam, looks really useful - I can read through and add some comments if that's useful? I see Hugo is already assigned though so happy to wait or let him do so instead |
Go ahead @pratikunterwegs. I am comfortable with having comments from everyone at the same time. Thank you! I just add one additional commit d2bd66d, so slightly different from the screenshot above, but I'm already done. |
Great thanks, will get some thoughts in by later today |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Looks great! Could you try to add more detailed alt texts please? Imagine you cannot see the image but still would like to know the information conveyed in the image.
You can find many resources on how to write good alt texts online. This can be a starter: https://support.microsoft.com/en-us/office/everything-you-need-to-know-to-write-effective-alt-text-df98f884-ca3d-456c-807b-1a1fa82f5dc2
orcid: "0000-0001-8814-9421" | ||
- name: "Rosalind M Eggo" | ||
orcid: "0000-0002-0362-6717" | ||
date: last-modified |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! I didn't know about this!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
possibly I spend too much time looking at the quarto documentation, hehe
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I now realize this may come with issues as we sometimes need to update already published posts (typos, breaking changes in quarto, broken URLs, etc.)
Thank you @Bisaloo for this edit suggestion. Following guidelines, a fair description of the figures does not fit in two sentences (See 8a5c3b2 for fig1). The node names have more words and connections than the tidyverse reference alt text that shows connections with a "Import -> Tidy" notation. So, a solution could be to redirect the reader to two data frames (df) in plain text format. This to allow the reading of:
If I follow this, my questions now are: Where to place those data frames? What format to use? I'll test a Markdown format and a HTML format at the end of the post. If needed, complementary files in the folder. Let me know your thoughts. |
for the record, I tried with the html outputs from draw_io/diagrams_net but those don't meet wcag standards for alt text due to the absence of aria labels. I found a HTML diagram that meets alt text standards from a11y, but no interphase tool to build them yet. I'll stick to the plan of the last message for now, as well as try more extensive alt text as an alternative too. Also, I'll look and ask for alternative tools to develop and deliver coming diagrams or concept maps. |
I think that I'll go for the complex image approach one to add a text link to a long description adjacent to the image. I'll try the quarto collapse callout for this. I found this option from this alt text decision tree. |
Hi Andree, sorry about the delay - overall I think it looks good, and we are already likely to use Fig. 1 for a meeting next week. Will let you know how that goes! |
Hi @avallecam, what's the status of this? Is it ready to be merged? |
No yet, Hugo. I leave this unattended while prioritizing other work. I'll retake this next week. Thank you for asking! |
Apologies for not looking at this before - this looks nice and has some really cool figures! If not too late here are a few suggestions:
|
Any updates on whether this PR will still be worked on? If not we can close it (please respond within next two weeks). |
Yes, it is on the plans to retake in June. Added to planning to increase visibility https://github.com/orgs/epiverse-trace/projects/33 |
Okay - I marked this as a draft PR until then. I am quite active on this repository and having open PRs that are not ready for consideration is quite confusing. It is considered best practice to only have PRs open that are ready for merging/closing and do not need any further work to be considered (as far as I know). I appreciate your patience as we work to streamline the management of repo issues + PRs. |
I'm locating this post as an entry in the "Learn" tab given its relationship with training materials. However, as mentioned at the end, we are already using it for {episoap} and package design documents. I also included some definitions shared in a recent gh-discussion post.
I added as coauthors to @CarmenTamayo @annacarnegie @sbfnk @adamkucharski @rozeggo. Let me know if this credits the team members who have contributed to this content.
Let me know your edit suggestions and questions regarding the content.