Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add script to scaffold new practice exercises #716

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

ErikSchierboom
Copy link
Member

No description provided.

- The tests should be based on the canonical data at 'https://github.com/exercism/problem-specifications/blob/main/exercises/${slug}/canonical-data.json'
- Any test cases you don't implement, mark them in 'exercises/practice/${slug}/.meta/tests.toml' with "include = false"
- Create the example solution in $(jq -r '.example' <<< "${files}")
- Verify the example solution passes the tests by running 'bin/verify-exercises ${slug}'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This refers to a bin/verify-exercises script that appears to be missing?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah. I'll update! Well spotted

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See #717

@ErikSchierboom ErikSchierboom force-pushed the add-practice-exercise-script branch from 6a9e399 to a506a33 Compare January 5, 2025 18:28
@ErikSchierboom
Copy link
Member Author

I've also updated the PR to write the namespaces to the solution, example and test files.

@tasxatzial
Copy link
Member

So is the scaffolding supposed to run only on linux? I tried it on windows with 'git bash' and it works fine. Only verifying the exercise seems to fail.

@ErikSchierboom
Copy link
Member Author

So is the scaffolding supposed to run only on linux? I tried it on windows with 'git bash' and it works fine. Only verifying the exercise seems to fail.

For Windows, I would recommend running it on WSL. Most tracks are maintained by users that are on Linux, or else have access to WSL.

@tasxatzial
Copy link
Member

Thanks, i'll give WSL a go. This will take some time given it's the first time i have to look at anything but exercises. So I'd like to do this properly, but if you are in a hurry, please go ahead and merge.

@ErikSchierboom ErikSchierboom merged commit a0e8928 into main Jan 8, 2025
2 checks passed
@ErikSchierboom ErikSchierboom deleted the add-practice-exercise-script branch January 8, 2025 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants