Add largest-series-product exercise
#8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That is the way I would have done it as well. A file with a named function, which is called by test-runner. Desriptions as comments, will become handy for later maintenance. For the C++ track I started to include UUIDs, to automate changing tests that keep the same name. |
ErikSchierboom
force-pushed
the
largest-series-product
branch
from
2ba3b07 to
68401bb
Compare
ErikSchierboom
force-pushed
the
largest-series-product
branch
from
68401bb to
a0bc63d
Compare
vaeng
approved these changes
Nov 12, 2024
ErikSchierboom
commented
Nov 12, 2024
Comment on lines
+1
to
+3
| Validate ← |2.2 ⍤ "span must be smaller than string length" ◡(≤⧻) ⍤ "span must not be negative" ≥0 , | ||
| Digits ← |1 ⍣(∵⋕) (⍤ "invalid character in digits") | ||
| LargestProduct ← |2 /↥ ≡/× ⍣(◫) [1] : Digits Validate |
There was a problem hiding this comment.
I must admit that being able to write this few characters and have it work makes me feel a little bit giddy :)
There was a problem hiding this comment.
Yes, I feel you. This lets me feel like I am in the matrix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@vaeng This is just to discuss what you think about the testing file. The test names are comments at the end of the line for now