Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Unison upgrade #142

Merged
merged 1 commit into from
Oct 7, 2024
Merged

The Unison upgrade #142

merged 1 commit into from
Oct 7, 2024

Conversation

SimaDovakin
Copy link
Contributor

  • Changed tests and test loaders.
  • Edited some example solutions.
  • Edited some track docs.

All CI tests will be failed for now. After the test runner deployment exercism/unison-test-runner#30 I will rerun all tests and merge this after approval. The track won't work after test runner deployment and before the merge of this PR temporarily.

- Changed tests and test loaders.
- Edited some example solutions.
- Edited some track docs.
@SimaDovakin SimaDovakin requested a review from rlmark October 5, 2024 11:03
@SimaDovakin SimaDovakin self-assigned this Oct 5, 2024
Copy link

github-actions bot commented Oct 5, 2024

This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested.

If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos.

[no important files changed]

For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping @exercism/maintainers-admin in a comment. Thank you!

@SimaDovakin SimaDovakin requested review from a team October 7, 2024 07:15
Copy link

@vaeng vaeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@SimaDovakin
Copy link
Contributor Author

@vaeng Thanks. Interesting, I can't merge this PR for some reason.

@SimaDovakin
Copy link
Contributor Author

I got it. In addition, I need an approval from @exercism/maintainers-admin.

@SimaDovakin SimaDovakin requested a review from vaeng October 7, 2024 07:55
@SimaDovakin SimaDovakin merged commit 86d9303 into main Oct 7, 2024
3 checks passed
@SimaDovakin SimaDovakin deleted the unison-upgrade branch October 7, 2024 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants