Feat: Add CIDR related actions #849
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for this contribution! I will try to review and merge it next week. |
fabian-hiller
force-pushed
the
main
branch
2 times, most recently
from
7a97dd0 to
b5f7f4d
Compare
|
I did not forget this PR. Sorry for the delay. I will try to review it soon. |
|
I just want to let you know that I am focusing on our v1 release first before reviewing this PR. |
Sounds good. Thanks for the updates. 🙂 |
fabian-hiller
force-pushed
the
main
branch
2 times, most recently
from
f41426c to
d713dfe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #342.
This PR adds 3 actions:
ipCidripv4Cidripv6CidrThese actions are for validating that an IP address is in CIDR notation.
The regular expressions added were verified with https://makenowjust-labs.github.io/recheck/playground/ and https://devina.io/redos-checker and both mark them as safe.
Some tests were added and the actions themselves have been added to the docs website.