Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(robots,security): add config serving bots and security #106

Merged
merged 2 commits into from
Jan 6, 2025
Merged

fix(robots,security): add config serving bots and security #106

merged 2 commits into from
Jan 6, 2025

Conversation

raisedadead
Copy link
Member

@raisedadead raisedadead commented Jan 3, 2025 •
edited
Loading

That should do it. Additionally need to make follow up PRs in the main repo to remove the security.txt from the static files.

@raisedadead raisedadead requested a review from a team as a code owner January 3, 2025 13:57
@raisedadead raisedadead marked this pull request as draft January 3, 2025 13:57
@raisedadead raisedadead force-pushed the fix/robots-txt branch 4 times, most recently from ae383e8 to 39d8170 Compare January 3, 2025 14:48
@raisedadead raisedadead marked this pull request as ready for review January 3, 2025 14:49
@raisedadead raisedadead changed the title fix(robots.txt): add config serving bots fix(robots,security): add config serving bots and security Jan 3, 2025
ojeytonwilliams
ojeytonwilliams approved these changes Jan 3, 2025
View reviewed changes
Copy link
Contributor

@ojeytonwilliams ojeytonwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not 100% comfortable with the map magic, but I think it all makes sense.

Let me know when it's live on staging and I'll test it.

@raisedadead raisedadead changed the base branch from main to qa January 6, 2025 07:24
@raisedadead raisedadead force-pushed the fix/robots-txt branch 2 times, most recently from 70e9965 to 2cf58fb Compare January 6, 2025 08:32
@raisedadead raisedadead merged commit e63035f into qa Jan 6, 2025
@raisedadead raisedadead deleted the fix/robots-txt branch January 6, 2025 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ojeytonwilliams ojeytonwilliams ojeytonwilliams approved these changes

Assignees
No one assigned
Labels
status: merge after deploy ⚠️
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@raisedadead @ojeytonwilliams