Add M-dim bindings #600
Open
Add M-dim bindings #600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JmsPae
commented
Jan 3, 2025
| } | ||
| Ok(wkb) | ||
| } | ||
|
|
There was a problem hiding this comment.
Maybe instead of a separate function, modifying the original wkb/wkt methods would be nicer, though that would be a breaking change.
JmsPae
commented
Jan 3, 2025
| pub fn geometry_type_has_m(ty: OGRwkbGeometryType::Type) -> bool { | ||
| unsafe { gdal_sys::OGR_GT_HasM(ty) != 0 } | ||
| } | ||
|
|
There was a problem hiding this comment.
Not sure about adding a bunch of stand-alone functions like this when they only take an OGRwkbGeometryType though since that's generated, this might just be good enough?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGES.mdif knowledge of this change could be valuable to users.This PR seeks to add bindings for GDAL functions relating to higher-dimension geometry, in particular Measured geometry, with some other minor fixes/additions.
Added methods for
Geometry:add_point_zmadd_point_mset_point_zmset_point_mget_point_zmget_point_vec_zmiso_wktiso_wkbConsidering renaming
get_point_vec_zmtoget_point_zm_vec, though neither exactly roll off the tongue.Also modified the Debug impl. for
Geometryto use iso_wkt in cases of measured geometry.