This repository has been archived by the owner on Sep 12, 2023. It is now read-only.
Print entire cause chain in case of actor restart #1638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the stop reason of a supervised actor only needed to implement `fmt::Display`. In practise however, we are always using an enum here that implements `std::error::Error`. The default impl of `Display` for an `Error` only prints the top-level cause. If the error contains a `cause`, it is the responsibility of the caller to walk the chain of causes and concatenate all the errors. Anyhow implements this logic for its own error type and it can be used by specifying the `alternate` modifier of `Display`: `#`. To construct an anyhow::Error, we change the trait requirements for the stop reason to implement `std::error::Error`.
thomaseizinger
force-pushed
the
chore/print-entire-reason-for-restart
branch
from
d472119 to
813353a
Compare
klochowicz
reviewed
Mar 16, 2022
It looks like other cause chains that we print out in the logs. They are concatenated with |
luckysori
approved these changes
Mar 16, 2022
| let reason_str = msg.reason.to_string(); | ||
| let should_restart = (self.restart_policy)(msg.reason); | ||
| let should_restart = (self.restart_policy)(&msg.reason); | ||
| let reason_str = format!("{:#}", anyhow::Error::new(msg.reason)); // Anyhow will format the entire chain of errors when using `alternate` Display (`#`) |
There was a problem hiding this comment.
👍 Nice trick. It's interesting that it's not easy to print the error chain without converting to anyhow::Error.
There was a problem hiding this comment.
It is in the works: rust-lang/project-error-handling#10 (comment)
|
bors r+ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the stop reason of a supervised actor only needed to
implement
fmt::Display. In practise however, we are always usingan enum here that implements
std::error::Error. The default impl ofDisplayfor anErroronly prints the top-level cause. If the errorcontains a
cause, it is the responsibility of the caller to walk thechain of causes and concatenate all the errors.
Anyhow implements this logic for its own error type and it can be used
by specifying the
alternatemodifier ofDisplay:#.To construct an anyhow::Error, we change the trait requirements for the
stop reason to implement
std::error::Error.