fix: improve QR code readability for different wallets #2804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reneaaron
force-pushed
the
fix/qr-codes
branch
2 times, most recently
from
17b1706 to
bfc1db4
Compare
reneaaron
force-pushed
the
fix/qr-codes
branch
from
bfc1db4 to
af37822
Compare
bumi
reviewed
Oct 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the changes you have made in this PR
lightning:prefix for lightning addresses QR code (consistent with what is displayed for invoices)ReceiveInvoicescreen and replaced it with ourResultCardTest results with different readers:
Legend
*don't support prefixed QR codes (lightning:)Since some of the wallets don't seem to support prefixed QR codes at the moment (Blixt, Breez, BlueWallet for lightning addresses) I think it's better to remove the prefix for now at the cost of not being able to scan the QR codes with QR code readers or your camera app and being able to directly click a link (but having to copy & paste the contents of the QR code, or just directly scan it with your wallet).