This repository has been archived by the owner on Nov 8, 2023. It is now read-only.
feat: Consumer that does nothing except poll #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Does nothing except poll and commit offsets every 100k messages. This consumer does not use any processing strategy or stream processor. The goal of this is to benchmark it's performance against the noop consumer.
|
Do you want to merge this PR or just try it out for testing? |
|
I wouldn't mind merging this and building some more iterations on top of it |
nikhars
reviewed
Jun 29, 2022
Comment on lines
+22
to
+29
| struct StrategyFactory { | ||
| batch_time: u64, | ||
| } | ||
| impl ProcessingStrategyFactory<KafkaPayload> for StrategyFactory { | ||
| fn create(&self) -> Box<dyn ProcessingStrategy<KafkaPayload>> { | ||
| Box::new(noop::new(Duration::from_millis(self.batch_time))) | ||
| } | ||
| } |
There was a problem hiding this comment.
This version does not require this code.
| } | ||
|
|
||
| fn main() { | ||
| let matches = App::new("noop consumer") |
There was a problem hiding this comment.
Suggested change
| let matches = App::new("noop consumer") | |
| let matches = App::new("consumer-only") |
| fn main() { | ||
| let matches = App::new("noop consumer") | ||
| .version(option_env!("CARGO_PKG_VERSION").unwrap_or("")) | ||
| .about("Simple noop consumer") |
There was a problem hiding this comment.
Suggested change
| .about("Simple noop consumer") | |
| .about("Simple consumer with no arroyo") |
This reverts commit 9d808c3.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does nothing except poll and commit offsets every 100k messages.
This consumer does not use any processing strategy or stream processor.
The goal of this is to benchmark it's performance against the noop consumer.