Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Improve & expose SentryOptions class #56

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from
Draft

feat: Improve & expose SentryOptions class #56

wants to merge 8 commits into from
+266 −127

Conversation

limbonaut
Copy link
Collaborator

@limbonaut limbonaut commented Jan 7, 2025 •
edited
Loading

This PR improves SentryOptions and exposes it in the public API. Needed for event hooks, in-code configuration support, integration tests and probably more.

Includes:

  • Expose SentryOptions in the public API
  • Add setters & bind properties
  • New macros to streamline property binding in ClassDB (reduce boilerplate)
  • Extract limits into its own public API class -- SentryLoggerLimits
  • Refactor SentryOptions loading from project settings

Resolves #55

Dependency for:

@limbonaut limbonaut added the enhancement New feature or request label Jan 7, 2025
@limbonaut limbonaut changed the title Improve SentryOptions class feat: Improve SentryOptions class Jan 7, 2025
@limbonaut limbonaut changed the title feat: Improve SentryOptions class feat: Expose SentryOptions class Jan 7, 2025
@limbonaut limbonaut changed the title feat: Expose SentryOptions class feat: Improve & expose SentryOptions class Jan 7, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 8, 2025 •
edited
Loading

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against cef47e8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Expose SentryOptions in the public API
1 participant
@limbonaut