chore(sentry apps): Audit & use new errors for external req processes & endpoints #83077
+69
−69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
❌ 1 Tests Failed:
View the top 1 failed tests by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
iamrajjoshi
reviewed
Jan 8, 2025
| @@ -45,7 +44,10 @@ def post(self, request: Request, installation) -> Response: | |||
| data = request.data.copy() | |||
|
|
|||
| if not {"groupId", "action", "uri"}.issubset(data.keys()): | |||
| return Response(status=400) | |||
| raise SentryAppError( | |||
| ValidationError('"groupId", "action", and "uri" must be present in request'), | |||
There was a problem hiding this comment.
nit: i would either use group_id or groupID, same everywhere else
| f"Invalid response format from sentry app {self.sentry_app} when linking issue" | ||
| raise SentryAppIntegratorError( | ||
| ValidationError( | ||
| f"Invalid response format from sentry app {self.sentry_app} when linking issue" |
There was a problem hiding this comment.
lets use integration instead of sentry app, not sure if we mention sentry app externally in docs.
| f"Something went wrong while getting SelectFields from {self.sentry_app.slug}" | ||
| raise SentryAppIntegratorError( | ||
| APIError( | ||
| f"Something went wrong while getting SelectFields from {self.sentry_app.slug}" |
There was a problem hiding this comment.
do integrators know what SelectFields is or is it something inside our code?
There was a problem hiding this comment.
Maybe ? The most accurate name is Select FormField so we could use that instead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title
Basically go through all the errors in external request (i.e when we make a req to the third party app for some data) processes and label SentryAppError or SentryAppIntegratorError.
For endpoints I went through and instead of returning a response for errors, we raise the error again and our base class error handler will deal with the error for us.