Fix all clippy lints #344
Open
Fix all clippy lints #344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarijnS95
force-pushed
the
clippy
branch
2 times, most recently
from
4682926 to
09beea7
Compare
MarijnS95
commented
Jan 2, 2025
Comment on lines
+93
to
95
| /// # Safety | ||
| /// TODO | ||
| pub unsafe fn from_queue_handle(queue: dispatch_queue_t) -> Self { |
There was a problem hiding this comment.
Handle is a raw pointer, and probably needs to be valid.
Comment on lines
72
to
77
| pub fn resolve_counter_range(&self, range: crate::NSRange) -> Vec<NSUInteger> { | ||
| let mut data = vec![0 as NSUInteger; range.length as usize]; | ||
| let total_bytes = range.length * mem::size_of::<NSUInteger>() as u64; | ||
| let total_bytes = mem::size_of_val(data.as_slice()) as u64; | ||
| unsafe { | ||
| let ns_data: *mut crate::Object = msg_send![self, resolveCounterRange: range]; | ||
| let () = msg_send![ns_data, getBytes: data.as_mut_ptr() length: total_bytes]; |
There was a problem hiding this comment.
Might actually be nice to use Vec::with_capacity() + spare_capacity_mut().
MarijnS95
force-pushed
the
clippy
branch
2 times, most recently
from
65abc0f to
5a0ebc6
Compare
This comment has been minimized.
This comment has been minimized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
metal-rsseems to have gotten quite behind onclippylints, making new contributions tedious thanks to almost 100 warnings in the CI (and in a local IDE).