Add R64Uint texture format #6453
Conversation
…r support detection for metal, directx, and vulkan
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
| @@ -3561,6 +3580,7 @@ impl TextureFormat { | |||
| | Self::Rg16Uint | |||
| | Self::Rgba16Uint | |||
| | Self::R32Uint | |||
| | Self::R64Uint | |||
There was a problem hiding this comment.
We should probably return None here if this is only meant to work with atomic ops.
There was a problem hiding this comment.
regular sampling should work with this format
There was a problem hiding this comment.
Will it on the APIs we emulate it on?
There was a problem hiding this comment.
I need it to, so consider that a blocking issue on the PR that actually implements this. Doesnt matter that it doesnt work with this PR because creating this texture errors every time anyways
| @@ -3860,6 +3881,7 @@ impl TextureFormat { | |||
| Self::R32Uint | |||
| | Self::R32Sint | |||
| | Self::R32Float | |||
| | Self::R64Uint | |||
| @@ -3780,6 +3800,7 @@ impl TextureFormat { | |||
| | Self::Rgba16Unorm | |||
| | Self::Rgba16Snorm | |||
| | Self::Rgba16Float | |||
| | Self::R64Uint | |||
|
Please add an error when creating a texture with this format (for people trying to use this new feature) because there are currently no checks in naga that this format is only used with atomic ops (which are currently not implemented). |
atlv24
force-pushed
the
r64-texture-format
branch
from
07b1608 to
5aa7e98
Compare
atlv24
force-pushed
the
r64-texture-format
branch
from
5aa7e98 to
a7538e3
Compare
| @@ -136,7 +136,7 @@ winit = { version = "0.29", features = ["android-native-activity"] } | |||
| # Metal dependencies | |||
| block = "0.1" | |||
| core-graphics-types = "0.1" | |||
| metal = { version = "0.29.0" } | |||
| metal = { version = "0.29.0", git = "https://github.com/gfx-rs/metal-rs.git", rev = "ae7030be0edff4cda88ece74137e5bcd28ef48fa" } | |||
There was a problem hiding this comment.
issue: We have a release impending, and we can't release to Crates.io with Git dependencies. This needs to be resolved upstream; I'm going to investigate releasing the current mainline history of Metal to see if this can be resolved before a WGPU release.
There was a problem hiding this comment.
I have a PR open upstream: gfx-rs/metal-rs#341
There was a problem hiding this comment.
metal v0.30.0 is now released!
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
|
We were hopeful to have #5537 as part of a minor release if we could get the breaking changes in before we release v23 but what I expected was that said breaking changes were refactors of existing code (#6451) and adding a few enum variants but this PR and #6459 are not doing just that, they are partially implementing the feature and I have a very hard time reviewing partial implementations. As @ErichDonGubler also mentioned on matrix, we shouldn't wait for PRs to land in order to release (unless they solve critical issues). |
Connections
commits pulled from #5537
Description
add r64uint texture format, wgpu feature, naga capability, and adapter support detection for metal, directx, and vulkan
Testing
tests are in #5537
Checklist
cargo fmt.taplo format.cargo clippy. If applicable, add:--target wasm32-unknown-unknown--target wasm32-unknown-emscriptencargo xtask testto run tests.CHANGELOG.md. See simple instructions inside file.