Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unconditionally Generate Bindless Samplers in DX12 #6766

Open
wants to merge 4 commits into
base: trunk
Choose a base branch
from

Conversation

cwfitzgerald
Copy link
Member

@cwfitzgerald cwfitzgerald commented Dec 17, 2024

Connections

Closes #3350
Depends on #6847

This PR should be reviewed commit by commit.

Description

We go bindless on our samplers yo

  • Fix codegen of binding arrays of samplers.
  • wgpu-hal changes
  • Tests

@cwfitzgerald cwfitzgerald changed the title DX12 Unconditionally Generate Bindless Samplers Unconditionally Generate Bindless Samplers in DX12 Dec 17, 2024
@cwfitzgerald cwfitzgerald force-pushed the cw/dx12-sampler-bindless branch 3 times, most recently from 1564ef7 to 80bcb42 Compare December 19, 2024 02:13
@cwfitzgerald cwfitzgerald force-pushed the cw/dx12-sampler-bindless branch 2 times, most recently from 1ec761b to 6b4b92c Compare January 2, 2025 19:52
@cwfitzgerald cwfitzgerald marked this pull request as ready for review January 2, 2025 20:11
@cwfitzgerald cwfitzgerald requested review from a team as code owners January 2, 2025 20:11
@cwfitzgerald cwfitzgerald mentioned this pull request Jan 2, 2025
7 tasks
@cwfitzgerald cwfitzgerald force-pushed the cw/dx12-sampler-bindless branch from 6b4b92c to 375e21e Compare January 2, 2025 20:19
@cwfitzgerald cwfitzgerald force-pushed the cw/dx12-sampler-bindless branch from 375e21e to d740d53 Compare January 2, 2025 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DX12 Sampler Heap Requirements Overly Strict
2 participants