Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename instance_id & instance_custom_index to instance_index & instance_custom_data #6780

Draft
wants to merge 19 commits into
base: trunk
Choose a base branch
from

Conversation

Vecvec
Copy link
Contributor

@Vecvec Vecvec commented Dec 18, 2024

Connections
based on #6752
fixes #6778

Description
instance_id is inconsistent with primitive_index and geometry_index

Testing
N/A

Checklist

  • Run cargo fmt.
  • [n/a] Run taplo format.
  • Run cargo clippy. If applicable, add:
    • [n/a] --target wasm32-unknown-unknown
    • [n/a] --target wasm32-unknown-emscripten
  • [n/a] Run cargo xtask test to run tests.
  • Add change to CHANGELOG.md. See simple instructions inside file.

@Vecvec Vecvec requested review from a team as code owners December 18, 2024 19:22
@cwfitzgerald
Copy link
Member

This diff is way larger than I would have expected this to be - what's going on here?

@Vecvec
Copy link
Contributor Author

Vecvec commented Dec 18, 2024

Oh, right, this is based on #6752, moving into draft. I forgot that when I was creating the PR.

@Vecvec Vecvec marked this pull request as draft December 18, 2024 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider renaming instance_id to instance_index.
2 participants