Type/Expression Tandem #6806
Open
Type/Expression Tandem #6806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kentslaney
force-pushed
the
compact-leak
branch
from
b21c0f5 to
babbb86
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections
Addresses #6788
Description
With the introduction of override-sized arrays, expressions can now refer to types. The existing compactor was built assuming a one directional dependency, meaning that unused types wouldn't have the supporting expressions removed. This PR removes that directionality assumption by tracing the types used by expressions in order to propagate usage. It also validates that any expression A that relies on a type that relies on another expression B has index A > B.
Testing
This is tested by checking that going from expression to type and back, along with the opposite, is correctly marked as used. The updated validation is checked by ensuring an error is raised when an out of order dependency is introduced.
Checklist
cargo fmt.taplo format.cargo clippy. If applicable, add:--target wasm32-unknown-unknown--target wasm32-unknown-emscriptencargo xtask testto run tests.CHANGELOG.md. See simple instructions inside file.