Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ray-tracing] Change index offset to first index #6873

Open
wants to merge 8 commits into
base: trunk
Choose a base branch
from

Conversation

Vecvec
Copy link
Contributor

@Vecvec Vecvec commented Jan 7, 2025

Connections
Mentioned on matrix as being confusing.

Description
index_buffer_offset is validated that the offset is divisible by the size of the index type, this suggests that it is probably better - and less confusing - if this is changed to be called first index and is multiplied by the size of the index type.

Testing
This is a change mostly to naming - it shouldn't need any new tests.

Checklist

  • Run cargo fmt.
  • Run taplo format.
  • Run cargo clippy. If applicable, add:
    • [n/a] --target wasm32-unknown-unknown
    • [n/a] --target wasm32-unknown-emscripten
  • Run cargo xtask test to run tests.
  • Add change to CHANGELOG.md. See simple instructions inside file.

@Vecvec Vecvec requested a review from a team as a code owner January 7, 2025 20:19
Copy link
Member

@cwfitzgerald cwfitzgerald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and matches how draw calls work

wgpu-core/src/command/ray_tracing.rs Outdated Show resolved Hide resolved
wgpu-core/src/command/ray_tracing.rs Outdated Show resolved Hide resolved
wgpu/src/api/blas.rs Outdated Show resolved Hide resolved
@Vecvec Vecvec requested a review from cwfitzgerald January 8, 2025 08:58
@cwfitzgerald cwfitzgerald self-assigned this Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants