[GHSA-mfj5-cf8g-g2fv] AsyncHttpClient (AHC) library's CookieStore replaces explicitly defined Cookies
#5084
Conversation
|
Hi there @hyperxpro! A community member has suggested an improvement to your security advisory. If approved, this change will affect the global advisory listed at github.com/advisories. It will not affect the version listed in your project repository. This change will be reviewed by our Security Curation Team. If you have thoughts or feedback, please share them in a comment here! If this PR has already been closed, you can start a new community contribution for this advisory |
github-actions
bot
changed the base branch from
main
to
pickypg/advisory-improvement-5084
|
Many thanks for the PR. Quick question on
Any chance you have a reference supporting that? Some issue where it was discussed or release notes or something? |
|
Good thing you asked, as I misinterpreted it: it should be in 2.1.0 and not 2.0.0. https://github.com/AsyncHttpClient/async-http-client/blob/main/CHANGES.md#from-20-to-21 |
| @@ -25,16 +25,13 @@ | |||
| "type": "ECOSYSTEM", | |||
| "events": [ | |||
| { | |||
| "introduced": "3.0.0" | |||
| "introduced": "2.0.0" | |||
There was a problem hiding this comment.
| "introduced": "2.0.0" | |
| "introduced": "2.1.0" |
There was a problem hiding this comment.
I had tried to apply this myself without realizing I don't have permission based on
https://github.com/AsyncHttpClient/async-http-client/blob/main/CHANGES.md#from-20-to-21
There was a problem hiding this comment.
All good. I'll take care of the change on the backend. Many thanks 👍
advisory-database
bot
merged commit e42a60b
into
pickypg/advisory-improvement-5084
|
Hi @pickypg! Thank you so much for contributing to the GitHub Advisory Database. This database is free, open, and accessible to all, and it's people like you who make it great. Thanks for choosing to help others. We hope you send in more contributions in the future! |
|
Should be good now, but let me know. I added the changelog as a reference as well 👍 |
Updates
Comments
CookieStoreissue was created with the initial 2.0 release.Note: GitHub forced me to change the Vector String, which I copied from the public CVE, because the one prepopulated failed to be parsed somehow. I do not want to change it.