bug: Branch Ruleset API call fails when a user/org doesn't have the ruleset feature #345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
src/functions/branch-ruleset-checks.js:71
- The help_text message is too long and may be truncated in some logging systems. Consider breaking it into multiple lines or shortening the message.
core.debug(ERROR.messages.upgrade_or_public.help_text)
Tip: Copilot code review supports C#, Go, Java, JavaScript, Markdown, Python, Ruby and TypeScript, with more languages coming soon. Learn more
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request handles an edge case / bug where the Branch Ruleset API call fails when a user or organization does not have the ruleset feature. The error would look something like this:
Since repository rulesets are not available on "free" accounts in "private" repos, this Action would fail. Since these checks are simply "warnings" to let users know if any misconfigurations are taking place, we should gracefully handle these errors and not fail the entire Action.
related: #342 (comment)
Example 📸
If you see a message like this:
... then you will likely not be able to utilize the branch ruleset checks that this Action performs.