Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Simplify main function by extracting new functions and adding tests #159

Merged
merged 3 commits into from
Nov 2, 2024

Conversation

zkoppert
Copy link
Member

@zkoppert zkoppert commented Nov 1, 2024

Pull Request

related to #91 but more work to be done to mark as completed

Proposed Changes

This pull request refactors the cleanowners.py script and adds new test cases to improve code maintainability and test coverage. The main changes include extracting the logic for fetching the CODEOWNERS file into a separate function and adding functions for printing statistics and writing reports. Corresponding unit tests have been added to ensure the new functions work correctly.

Readiness Checklist

Author/Contributor

  • If documentation is needed for this change, has that been included in this pull request
  • run make lint and fix any issues that you have introduced
  • run make test and ensure you have test coverage for the lines you are introducing
  • If publishing new data to the public (scorecards, security scan results, code quality results, live dashboards, etc.), please request review from @jeffrey-luszcz

Reviewer

  • Label as either fix, documentation, enhancement, infrastructure, maintenance or breaking

@zkoppert zkoppert self-assigned this Nov 1, 2024
@zkoppert zkoppert changed the title Simplify main function by extracting new functions and adding tests refactor: Simplify main function by extracting new functions and adding tests Nov 1, 2024
@zkoppert zkoppert changed the title refactor: Simplify main function by extracting new functions and adding tests chore: Simplify main function by extracting new functions and adding tests Nov 2, 2024
@zkoppert zkoppert merged commit 3483925 into main Nov 2, 2024
32 checks passed
@zkoppert zkoppert deleted the simplify-main-fn branch November 2, 2024 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants