Add error handling to test

github · Jan 7, 2025 · b3d8c6b · b3d8c6b
1 parent 60cf1ec
commit b3d8c6b
Showing 1 changed file with 23 additions and 0 deletions.
diff --git a/go/ql/test/library-tests/semmle/go/dataflow/flowsources/local/database/test_database_sql.go b/go/ql/test/library-tests/semmle/go/dataflow/flowsources/local/database/test_database_sql.go
@@ -18,6 +18,9 @@ func testConnQuery(conn *sql.Conn) {
 		var id int
 		var name string
 		err = rows.Scan(&id, &name)
+		if err != nil {
+			return
+		}
 
 		sink(id, name) // $ hasTaintFlow="id" hasTaintFlow="name"
 	}
@@ -50,6 +53,10 @@ func testDBQuery(db *sql.DB) {
 		var name string
 		err = rows.Scan(&id, &name)
 
+		if err != nil {
+			return
+		}
+
 		sink(id, name) // $ hasTaintFlow="id" hasTaintFlow="name"
 	}
 
@@ -84,6 +91,10 @@ func testStmtQuery(stmt *sql.Stmt) {
 		var name string
 		err = rows.Scan(&id, &name)
 
+		if err != nil {
+			return
+		}
+
 		sink(id, name) // $ hasTaintFlow="id" hasTaintFlow="name"
 	}
 
@@ -94,6 +105,10 @@ func testStmtQuery(stmt *sql.Stmt) {
 
 	err = row.Scan(&id, &name)
 
+	if err != nil {
+		return
+	}
+
 	sink(id, name) // $ hasTaintFlow="id" hasTaintFlow="name"
 
 	dog := stmt.QueryRow("SELECT * FROM dogs WHERE id = 1") // $ source
@@ -117,6 +132,10 @@ func testTxQuery(tx *sql.Tx) {
 		var name string
 		err = rows.Scan(&id, &name)
 
+		if err != nil {
+			return
+		}
+
 		sink(id, name) // $ hasTaintFlow="id" hasTaintFlow="name"
 	}
 
@@ -127,6 +146,10 @@ func testTxQuery(tx *sql.Tx) {
 
 	err = row.Scan(&id, &name)
 
+	if err != nil {
+		return
+	}
+
 	sink(id, name) // $ hasTaintFlow="id" hasTaintFlow="name"
 
 	dog := tx.QueryRow("SELECT * FROM dogs WHERE id = 1") // $ source