-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
C# 13: Allows ref struct. #18385
Draft
michaelnebel
wants to merge
14
commits into
github:main
Choose a base branch
from
michaelnebel:csharp/allowsrefstruct
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
C# 13: Allows ref struct. #18385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelnebel
force-pushed
the
csharp/allowsrefstruct
branch
from
January 3, 2025 14:31
70f2958
to
fd26958
Compare
…meter constraint.
michaelnebel
force-pushed
the
csharp/allowsrefstruct
branch
from
January 3, 2025 14:36
fd26958
to
d336e1d
Compare
michaelnebel
force-pushed
the
csharp/allowsrefstruct
branch
from
January 3, 2025 15:28
d336e1d
to
caaf291
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR we introduce support for the
allows ref struct
type parameter constraint. The language feature is described here.A couple of notes on the implementation.
ref struct
type can not be implicitly converted to adynamic
type,object
orValueType
.allows ref struct
is a negative constraint meaning that it extends the number of types that can be used as type replacement for a type parameter.The unification and dispatch call logic has been adapted to take the
allows ref struct
constraint into account (relevant for dynamic dispatch) for deciding relevant dispatch targets. To make things easier a new classRefStruct
has been introduced in the type hierarcy. One could consider whether we want to change the type hierarchy such thatRefStruct
doesn't extendStruct
(and therebyValueType
). Not sure whether this is worth it.Furthermore, we also extract the
notnull
general type parameter constraint.