Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Use backticks to format file name in adding-a-theme-to-your-github-pages-site-using-jekyll#adding-a-theme #35821 #35850

Closed

Conversation

thedarkking01
Copy link
Contributor

@thedarkking01 thedarkking01 commented Jan 7, 2025

Fix: Use backticks to format file name in adding-a-theme-to-your-github-pages-site-using-jekyll#adding-a-theme #35821

  • Updated the article to use backticks for file names in "Adding a theme to your GitHub Pages site using Jekyll".
  • Modified the _config.yml references to follow the GitHub Docs style guide.

Why:

Closes: #35821

What's being changed (if available, include any code snippets, screenshots, or gifs):

Changed :

  1. Navigate to _config.yml.

To:

  1. Navigate to _config.yml.

Check off the following:

  • A subject matter expert (SME) has reviewed the technical accuracy of the content in this PR. In most cases, the author can be the SME. Open source contributions may require a SME review from GitHub staff.
  • The changes in this PR meet the docs fundamentals that are required for all content.
  • All CI checks are passing.

Copy link

welcome bot commented Jan 7, 2025

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Jan 7, 2025
Copy link
Contributor

github-actions bot commented Jan 7, 2025

👋 Hey there spelunker. It looks like you've modified some files that we can't accept as contributions:

  • package.json

You'll need to revert all of the files you changed that match that list using GitHub Desktop or git checkout origin/main <file name>. Once you get those files reverted, we can continue with the review process. :octocat:

The complete list of files we can't accept are:

  • .devcontainer/**
  • .github/**
  • data/reusables/rai/**
  • Dockerfile*
  • src/**
  • package*.json
  • content/actions/deployment/security-hardening-your-deployments/**

We also can't accept contributions to files in the content directory with frontmatter type: rai.

Copy link
Contributor

github-actions bot commented Jan 7, 2025

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.


Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
pages/setting-up-a-github-pages-site-with-jekyll/adding-a-theme-to-your-github-pages-site-using-jekyll.md fpt
ghec
ghes@ 3.15 3.14 3.13 3.12 3.11 3.10
fpt
ghec
ghes@ 3.15 3.14 3.13 3.12 3.11 3.10

fpt: Free, Pro, Team
ghec: GitHub Enterprise Cloud
ghes: GitHub Enterprise Server

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triage Do not begin working on this issue until triaged by the team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use backticks to format file name in adding-a-theme-to-your-github-pages-site-using-jekyll#adding-a-theme
1 participant