Fix MinGW compilation error because of new library ABI #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ark0f
force-pushed
the
mingw-compilation-fix
branch
from
117ed3a to
c1fad17
Compare
antiagainst
reviewed
May 2, 2020
| @@ -33,6 +36,9 @@ fn build_shaderc(shaderc_dir: &PathBuf, use_ninja: bool) -> PathBuf { | |||
| .define("SPIRV_WERROR", "OFF") | |||
| .define("SHADERC_SKIP_TESTS", "ON") | |||
| .define("CMAKE_INSTALL_LIBDIR", "lib"); | |||
| if target_os == "windows" && target_env == "gnu" { | |||
| config.define("_GLIBCXX_USE_CXX11_ABI", "0"); | |||
There was a problem hiding this comment.
Thanks for the patch. I'm not very familiar with the MinGW environment. So MinGW actually uses the old ABI? Is this safe if they later change to the new ABI? Is there a way to detect which ABI to use?
It would be nice to paste the link here as a comment so folks can easily discover the reason of this definition. :)
|
Ah, actually this PR doesn't solve the problem and I don't know how to fix it. Sorry for wasted time. I opened issue to understand what problem is: #75 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation