Update attribute name to fix the non-acceptance of cli kwargs for earthengine #491
+6
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. |
Piyush-Ingale
approved these changes
Jan 7, 2025
mahrsee1997
approved these changes
Jan 7, 2025
There was a problem hiding this comment.
LGTM ! Thanks @kbp45-cusp for this change :)
Please bump the weather-mv version in setup.py.
This is done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current version of weather mover is unable pass the CLI xarray_open_dataset_kwargs argument to ConvertToAsset correctly.
As the ConvertToAsset is a dataclass, only the attributes defined in the class will be picked up from the kwargs provided via CLI while initialization (https://github.com/google/weather-tools/blob/main/weather_mv/loader_pipeline/sinks.py#L55). As the current attribute name is open_dataset_kwargs which doesn't match the argument provided from the CLI (xarray_open_dataset_kwargs), the xarray open dataset arguments are not being passed correctly. This PR fixes this issue.
Reference for removal of Mambaforge: conda-forge/miniforge#704