Require a more recent version of pkg-config #317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Require a more recent version of pkg-config, since "0.3.0" doesn't actually compile using recent versions of rustc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cargo.toml says that zstd requires pkg-config "0.3".
This version specification is typically resolved to the most recent pkg-config, but technically, it could be resolved to "0.3.0". However, this version of pkg-config is almost 10 years old, and does not actually work with zstd.
Some projects use a CI-step that checks that selecting minimum versions of all dependencies actually works, and such CI now fails if zstd is in the project crate graph, because of this issue.
We should require a more recent version of pkg-config. I arbitrarily selected "0.3.28", but of course the most recent one will actually be selected for most users. This PR just steps the pkg-config version to 0.3.28. The earliest version that actually compiles is "0.3.7", but it seems strange to explicitly name such an old version.