Update canonical links for Advanced section #453
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for harvester-preview ready!
|
There was a problem hiding this comment.
@LucasSaintarbor Some URLs have changed.
/advanced/settings/->/advanced/index//advanced/pcidevices/->/advanced/addons/pcidevices//advanced/vmimport/->/advanced/addons/vmimport/
Co-authored-by: Jillian <[email protected]>
LucasSaintarbor
commented
Jan 30, 2024
There was a problem hiding this comment.
@jillian-maroket Sorry I missed this. For /advanced/settings -> /advanced/index/, removing the id: index in the metadata makes the URL /advanced/settings. I made this change to make the URL match the title in the sidebar/of the page.
| sidebar_position: 1 | ||
| sidebar_label: Settings | ||
| title: "Settings" | ||
| --- | ||
|
|
||
| <head> | ||
| <link rel="canonical" href="https://docs.harvesterhci.io/v1.1/advanced/settings"/> | ||
| <link rel="canonical" href="https://docs.harvesterhci.io/v1.2/advanced/index"/> |
There was a problem hiding this comment.
Suggested change
| <link rel="canonical" href="https://docs.harvesterhci.io/v1.2/advanced/index"/> | |
| <link rel="canonical" href="https://docs.harvesterhci.io/v1.2/advanced/settings"/> |
| sidebar_position: 1 | ||
| sidebar_label: Settings | ||
| title: "Settings" | ||
| --- | ||
|
|
||
| <head> | ||
| <link rel="canonical" href="https://docs.harvesterhci.io/v1.1/advanced/settings"/> | ||
| <link rel="canonical" href="https://docs.harvesterhci.io/v1.2/advanced/index"/> |
There was a problem hiding this comment.
Suggested change
| <link rel="canonical" href="https://docs.harvesterhci.io/v1.2/advanced/index"/> | |
| <link rel="canonical" href="https://docs.harvesterhci.io/v1.2/advanced/settings"/> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: Tracking adding canonical links for v1.2 via https://github.com/harvester/docs/issues/446. Wait to merge until #434 is merged.