Pass our configured random reader into nodee functions #4372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jefferai
force-pushed
the
jefferai-random-reader-through-nodee
branch
3 times, most recently
from
2876cca to
af41f4a
Compare
jefferai
force-pushed
the
jefferai-random-reader-through-nodee
branch
2 times, most recently
from
4bb50c8 to
0b09505
Compare
jefferai
force-pushed
the
jefferai-random-reader-through-nodee
branch
2 times, most recently
from
7c29c95 to
8ab4bc7
Compare
jefferai
force-pushed
the
jefferai-random-reader-through-nodee
branch
from
8ab4bc7 to
c6490cf
Compare
irenarindos
reviewed
Apr 22, 2024
| @@ -49,3 +53,10 @@ func WithCertificateLifetime(with time.Duration) Option { | |||
| o.withCertificateLifetime = with | |||
| } | |||
| } | |||
|
|
|||
| // WithRandomReader provides a way to specify a random reader | |||
There was a problem hiding this comment.
Should a opts test be added for this?
| // Supported options: | ||
| // | ||
| // * WithLimit: default limit on results returned by repo operations | ||
| // * RandomReader: Specify a specific random source |
There was a problem hiding this comment.
Suggested change
| // * RandomReader: Specify a specific random source | |
| // * WithRandomReader: Specify a specific random source |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note for reviewers: in some places where there are already options I'm using options, and in other places I added something to the signature. If this feels odd I can modify it to be consistent one way or the other, happy to take feedback on that.