You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This separates out the configuration for preserving file ownership vs other attributes. Preserving ownership requires root permissions, and attempting to do that without root permissions now fails instead of just warning. The rationale for separating the options rather than just requiring root to preserve any of the attributes is that there are many use cases where the file mode and modification times are important, but where file ownership is not. This way users can benefit from these attributes without needing root privileges.
I will pause on this for now @NodyHub as I think I'll need your help with setting up the rar test data to check it is preserving the UID/GID during packing.
I will pause on this for now @NodyHub as I think I'll need your help with setting up the rar test data to check it is preserving the UID/GID during packing.
As mentioned in #106 (comment) the rar library has currently no support to extract the uid/gid from the file, so the test case is expected to fail 🙈
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This separates out the configuration for preserving file ownership vs other attributes. Preserving ownership requires root permissions, and attempting to do that without root permissions now fails instead of just warning. The rationale for separating the options rather than just requiring root to preserve any of the attributes is that there are many use cases where the file mode and modification times are important, but where file ownership is not. This way users can benefit from these attributes without needing root privileges.