-
-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adopt core::error::Error, update nightly, update bootloader #502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that error in core is stable on Rust 1.81.0, adopt it in the HAL crates and stuff.
Update our Rust toolchain to nightly-2025-01-01, and update `bootloader` to compile on that version. It currently panics because the latest bootloader maps some stuff on huge pages which we don't expect...
hawkw
added a commit
that referenced
this pull request
Jan 4, 2025
Currently the code for finding or creating the next-level page table for a page will bail out if the entry pointing to the page table is a huge page. This is because we don't currently support *mapping* huge pages. But, if a present page table entry set up by the bootloader happens to be a huge page, that's fine and we can still twiddle the mappings on that table. This fixes the kernel crashing with the latest `bootloader` crate. Fixes #501
hawkw
added a commit
that referenced
this pull request
Jan 4, 2025
hawkw
force-pushed
the
eliza/core-error
branch
from
January 4, 2025 20:02
4edfdd2
to
49cbf94
Compare
hawkw
added a commit
that referenced
this pull request
Jan 4, 2025
hawkw
added a commit
that referenced
this pull request
Jan 4, 2025
hawkw
added a commit
that referenced
this pull request
Jan 4, 2025
hawkw
added a commit
that referenced
this pull request
Jan 4, 2025
hawkw
added a commit
that referenced
this pull request
Jan 4, 2025
hawkw
added a commit
that referenced
this pull request
Jan 4, 2025
Apparently `default_features` is deprecated and will be removed in Rust 2024. So fix that, I guess.
Currently the code for finding or creating the next-level page table for a page will bail out if the entry pointing to the page table is a huge page. This is because we don't currently support *mapping* huge pages. But, if a present page table entry set up by the bootloader happens to be a huge page, that's fine and we can still twiddle the mappings on that table. This fixes the kernel crashing with the latest `bootloader` crate. Fixes #501
Apparently `default_features` is deprecated and will be removed in Rust 2024. So fix that, I guess.
hawkw
force-pushed
the
eliza/core-error
branch
from
January 4, 2025 20:25
16336e3
to
5c4d6fe
Compare
Closed
hawkw
added a commit
that referenced
this pull request
Jan 4, 2025
Now that error in core is stable on Rust 1.81.0, adopt it in the HAL crates and stuff.
hawkw
added a commit
that referenced
this pull request
Jan 4, 2025
Update our Rust toolchain to nightly-2025-01-01, and update `bootloader` to compile on that version. It currently panics because the latest bootloader maps some stuff on huge pages which we don't expect...
hawkw
added a commit
that referenced
this pull request
Jan 4, 2025
Currently the code for finding or creating the next-level page table for a page will bail out if the entry pointing to the page table is a huge page. This is because we don't currently support *mapping* huge pages. But, if a present page table entry set up by the bootloader happens to be a huge page, that's fine and we can still twiddle the mappings on that table. This fixes the kernel crashing with the latest `bootloader` crate. Fixes #501
hawkw
added a commit
that referenced
this pull request
Jan 4, 2025
hawkw
added a commit
that referenced
this pull request
Jan 4, 2025
hawkw
added a commit
that referenced
this pull request
Jan 4, 2025
hawkw
added a commit
that referenced
this pull request
Jan 4, 2025
hawkw
added a commit
that referenced
this pull request
Jan 4, 2025
hawkw
added a commit
that referenced
this pull request
Jan 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.