Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adopt core::error::Error, update nightly, update bootloader #502

Merged
merged 11 commits into from
Jan 4, 2025

Conversation

hawkw
Copy link
Owner

@hawkw hawkw commented Jan 4, 2025

No description provided.

hawkw added 2 commits January 4, 2025 11:48
Now that error in core is stable on Rust 1.81.0, adopt it in the HAL
crates and stuff.
Update our Rust toolchain to nightly-2025-01-01, and update `bootloader`
to compile on that version.

It currently panics because the latest bootloader maps some stuff on
huge pages which we don't expect...
hawkw added a commit that referenced this pull request Jan 4, 2025
Currently the code for finding or creating the next-level page table
for a page will bail out if the entry pointing to the page table is a
huge page. This is because we don't currently support *mapping* huge
pages. But, if a present page table entry set up by the bootloader
happens to be a huge page, that's fine and we can still twiddle the
mappings on that table.

This fixes the kernel crashing with the latest `bootloader` crate.

Fixes #501
hawkw added a commit that referenced this pull request Jan 4, 2025
Thanks clippy for reminding me to have these.
@hawkw hawkw force-pushed the eliza/core-error branch from 4edfdd2 to 49cbf94 Compare January 4, 2025 20:02
hawkw added a commit that referenced this pull request Jan 4, 2025
hawkw added a commit that referenced this pull request Jan 4, 2025
hawkw added a commit that referenced this pull request Jan 4, 2025
hawkw added a commit that referenced this pull request Jan 4, 2025
hawkw added a commit that referenced this pull request Jan 4, 2025
Apparently `default_features` is deprecated and will be removed in Rust
2024. So fix that, I guess.
@hawkw hawkw marked this pull request as ready for review January 4, 2025 20:22
@hawkw hawkw enabled auto-merge (rebase) January 4, 2025 20:22
hawkw added 9 commits January 4, 2025 12:25
Currently the code for finding or creating the next-level page table
for a page will bail out if the entry pointing to the page table is a
huge page. This is because we don't currently support *mapping* huge
pages. But, if a present page table entry set up by the bootloader
happens to be a huge page, that's fine and we can still twiddle the
mappings on that table.

This fixes the kernel crashing with the latest `bootloader` crate.

Fixes #501
Thanks clippy for reminding me to have these.
Apparently `default_features` is deprecated and will be removed in Rust
2024. So fix that, I guess.
@hawkw hawkw force-pushed the eliza/core-error branch from 16336e3 to 5c4d6fe Compare January 4, 2025 20:25
@hawkw hawkw mentioned this pull request Jan 4, 2025
@hawkw hawkw merged commit fb4f514 into main Jan 4, 2025
17 of 18 checks passed
@hawkw hawkw deleted the eliza/core-error branch January 4, 2025 20:59
hawkw added a commit that referenced this pull request Jan 4, 2025
Now that error in core is stable on Rust 1.81.0, adopt it in the HAL
crates and stuff.
hawkw added a commit that referenced this pull request Jan 4, 2025
Update our Rust toolchain to nightly-2025-01-01, and update `bootloader`
to compile on that version.

It currently panics because the latest bootloader maps some stuff on
huge pages which we don't expect...
hawkw added a commit that referenced this pull request Jan 4, 2025
Currently the code for finding or creating the next-level page table
for a page will bail out if the entry pointing to the page table is a
huge page. This is because we don't currently support *mapping* huge
pages. But, if a present page table entry set up by the bootloader
happens to be a huge page, that's fine and we can still twiddle the
mappings on that table.

This fixes the kernel crashing with the latest `bootloader` crate.

Fixes #501
hawkw added a commit that referenced this pull request Jan 4, 2025
Thanks clippy for reminding me to have these.
hawkw added a commit that referenced this pull request Jan 4, 2025
hawkw added a commit that referenced this pull request Jan 4, 2025
hawkw added a commit that referenced this pull request Jan 4, 2025
hawkw added a commit that referenced this pull request Jan 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant