Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

APIs for external libraries #87

Open
wants to merge 10 commits into
base: dev
Choose a base branch
from
Open

APIs for external libraries #87

wants to merge 10 commits into from

Conversation

fedebenelli
Copy link
Member

@fedebenelli fedebenelli commented Jul 12, 2024

This pull request focuses on the wrapping of external libraries, at the end of the pull requests it should include

  • Wrappers to known libraries:

    • FeOs

      • Object saving pointer
      • json string generator
      • Model calling interface
    • teqp

      • Object saving pointer
      • json string generator
      • Model calling interface
  • Maybe some C API standard type?

  • Move the C-API of yaeos-python to be called from other C libraries

Copy link

codecov bot commented Jul 12, 2024

Codecov Report

Attention: Patch coverage is 42.69663% with 51 lines in your changes missing coverage. Please review.

Project coverage is 91.97%. Comparing base (e8aa28b) to head (5765ab1).

Files Patch % Lines
src/fitting/fit_nrtl_mhv.f90 0.00% 38 Missing ⚠️
src/models/external_apis/feos.f90 75.75% 8 Missing ⚠️
src/fitting/fitting.f90 58.33% 4 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev      #87      +/-   ##
==========================================
- Coverage   93.60%   91.97%   -1.63%     
==========================================
  Files          53       56       +3     
  Lines        2392     2468      +76     
  Branches      179      179              
==========================================
+ Hits         2239     2270      +31     
- Misses        105      150      +45     
  Partials       48       48              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant