feat(driver): Sound option with TerminalNotifierDriver #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello. Thanks for your first contribution 💛 I like it! (This project is going wild 😅) It seems this PR breaks some CI tests. Could you have a look at it? Could you also add a note in the CHANGELOG? And I'm not sure, but I may deserve a doc entry |
|
Hello ! Thank you for your review ! I added some documentation to inform that TerminalNotifierDriver now supports the sound option but I don't see in the doc where I could add an entire entry |
|
Your contribution looks good to me and the doc you updated is enough. BUT you edited the wrong chapter ( I will merge your PR as soon this is fixed 😉 |
|
My bad 😅 I fixed it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.