Updated and optimised Dockerfile and modified dockerignore #1245
Conversation
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1245 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 10 10
Lines 373 373
Branches 94 94
=========================================
Hits 373 373 ☔ View full report in Codecov by Sentry. |
|
Thank you @abhayymishraa for the PR. One questions.... Dockerfile will become compatible with Windows machines also? |
|
@DhairyaMajmudar i ran a test in my friend's system (windows 11 ) . it worked smoothly |
|
@DhairyaMajmudar done ✔️ |
There was a problem hiding this comment.
This is unmaintainable. If this is the best way to install yarn, I think it's too soon to move away from corepack. Corepack isn't gone yet and it appears that Yarn doesn't have a reasonable path to installing without it yet. I say we wait until this situation improves before trying to remove corepack.
|
yes , The curl is the way to get that specific package without any problem although i have a alternative i found out recently looking forward to soon make a pr with the changes |
What kind of change does this PR introduce?
Issue Number:
Screenshots/videos:
If relevant, did you update the documentation?
N/A
Summary
The Dockerfile has been optimized to include proper Yarn 4.4.0 installation from source, enhanced cleanup processes to
reduce image size, improved environment file handling, and explicit command execution, resulting in a more efficient and
reliable container build process.
Does this PR introduce a breaking change?
N/A