add single user server spawn delay and user-facing message #825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1) allows admins to add a delay to single-user server spawns (useful for testing) 2) adds a configurable message to present to users after an amount of time has passed, imploring patience
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
|
I'm not a fan of adding properties just for testing, especially since we already have a lot of complicated configuration properties, and it's trivial to add a delay by subclassing the spawner in-line in the Z2JH config. A custom user message about the delay sounds useful though. Is there any way to put this in the parent class so it's available to all spawners, or is it inherently tied to KubeSpawner? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR allows admins to add a delay to single-user server spawns (useful for testing), and adds a configurable message to present to users after an amount of time has passed, imploring patience.
adding a delay was useful in debugging some grafana metrics (berkeley-dsep-infra/datahub#4237, berkeley-dsep-infra/datahub#4241).
the 'patience message' was added as users would believe that hubs were down/not working/etc when it took longer than a couple of minutes to launch their notebooks, particularly when a new GCP node was spinning up during peak usage times (berkeley-dsep-infra/datahub#3845, berkeley-dsep-infra/datahub#3963).
this has been incredibly useful for us at UC Berkeley and has saved both us and our users many hours of unnecessary support and debugging requests due to slow launches.
ref: #651