Dynatemp ooba hf #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Currently doesn't take minTemp and maxTemp as proper arguments, so it's hardcoded to 0.0 minTemp and 2.0 maxTemp for now - Atm it's hardcoded to only trigger if the "dynatemp" UI variable is above 0.8. This should be a bool and the UI should also have minTemp and maxTemp - For obvious reasons, the regular temperature shouldn't apply when Dynamic Temp is on either - Right now it runs after the truncation samplers always, but it should respect the "temperature_last" argument and come either first or last depending on that bool
more work to be done elsewhere
this is an attempt to fix it
Disregard last commit name btw
Last commit also ensured the default value is zero for dynatemp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a merge conflict, ignore