Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @sdogruyol !
I'm now heavily using
basic_auth
and it would be nice if we can call it in several times for independency of pages. This PR enables it.Impact
HTTPBasicAuth.runtime
method that keeps singleton instance object. This looks like well knownINSTANCE
technic except instantiating it lazily due to add_handler stuff.basic_auth
is now a simple proxy to theruntime
. Thus, we can accumulate entries.I'm glad if you like this! I'll create a new PR soon for a limited page authorization. 😄
Thanks.