Add an option to log to stdout #1473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rockstorm101, @Fat-Zer, Reminder to myself: Best regards, DD |
printrun/pronterface.py
Outdated
| @@ -81,35 +81,38 @@ def format_length(mm, fractional=2): | |||
| return '%%.%df' % fractional % units + suffix | |||
|
|
|||
| class ConsoleOutputHandler: | |||
| """Handle console output. All messages go through the logging submodule. We setup a logging handler to get logged messages and write them to both stdout (unless a log file path is specified, in which case we add another logging handler to write to this file) and the log panel. | |||
| We also redirect stdout and stderr to ourself to catch print messages and al.""" | |||
| """Handle console output. All messages go through the logging submodule. We setup a logging handler to get logged | |||
There was a problem hiding this comment.
Thanks for wrapping this test. Could we please wrap at 78 characters though? Something like this:
class ConsoleOutputHandler:
- """Handle console output. All messages go through the logging submodule. We setup a logging handler to get logged
- messages and write them to both stdout (unless a log file path is specified, in which case we add another logging
- handler to write to this file) and the log panel. We also redirect stdout and stderr to ourselves to catch print
- messages and al."""
+ """Handle console output. All messages go through the logging
+ submodule. We setup a logging handler to get logged messages and write
+ them to both stdout (unless a log file path is specified, in which case we
+ add another logging handler to write to this file) and the log panel. We
+ also redirect stdout and stderr to ourselves to catch print messages and
+ all."""
printrun/pronterface.py
Outdated
| """Handle console output. All messages go through the logging submodule. We setup a logging handler to get logged | ||
| messages and write them to both stdout (unless a log file path is specified, in which case we add another logging | ||
| handler to write to this file) and the log panel. We also redirect stdout and stderr to ourselves to catch print | ||
| messages and al.""" |
| self.stdout = sys.stdout | ||
| self.stderr = sys.stderr | ||
| sys.stdout = self | ||
| sys.stderr = self | ||
| self.print_on_stdout = not log_path | ||
| if log_path: |
There was a problem hiding this comment.
I was worried about removing this check, but in my tests I could not make it fail due to this removal. So I'm happy with it. But if you could double check I would appreciate it.
There was a problem hiding this comment.
it was redundant: there is already the same check in setup_logging()
Fat-Zer
commented
Dec 31, 2024
printrun/pronterface.py
Outdated
| @@ -81,35 +81,38 @@ def format_length(mm, fractional=2): | |||
| return '%%.%df' % fractional % units + suffix | |||
|
|
|||
| class ConsoleOutputHandler: | |||
| """Handle console output. All messages go through the logging submodule. We setup a logging handler to get logged messages and write them to both stdout (unless a log file path is specified, in which case we add another logging handler to write to this file) and the log panel. | |||
| We also redirect stdout and stderr to ourself to catch print messages and al.""" | |||
| """Handle console output. All messages go through the logging submodule. We setup a logging handler to get logged | |||
printrun/pronterface.py
Outdated
| """Handle console output. All messages go through the logging submodule. We setup a logging handler to get logged | ||
| messages and write them to both stdout (unless a log file path is specified, in which case we add another logging | ||
| handler to write to this file) and the log panel. We also redirect stdout and stderr to ourselves to catch print | ||
| messages and al.""" |
| self.stdout = sys.stdout | ||
| self.stderr = sys.stderr | ||
| sys.stdout = self | ||
| sys.stderr = self | ||
| self.print_on_stdout = not log_path | ||
| if log_path: |
There was a problem hiding this comment.
it was redundant: there is already the same check in setup_logging()
|
Many thanks for your contribution here! 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: https://github.com/Fat-Zer/Printrun/pull/new/log-stdout